Avoid silently wrong results on 10bit CUDA #777
+90
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
scotts
reviewed
Jul 14, 2025
| // AVFrame is on GPU memory. It can be on CPU memory if the video isn't | ||
| // supported by NVDEC for whatever reason: NVDEC falls back to CPU decoding in | ||
| // this case, and our check fails. | ||
| // TODO: we could send the frame back into the CPU path, and rely on |
There was a problem hiding this comment.
Let's create an issue to track.
scotts
reviewed
Jul 14, 2025
|
|
||
| AVPixelFormat actualFormat = | ||
| reinterpret_cast<AVHWFramesContext*>(avFrame->hw_frames_ctx->data) | ||
| ->sw_format; |
There was a problem hiding this comment.
I got tripped up reading this because I'm not used to seeing a reinterpret_cast inside of an expression. I think it's easier to read as:
hwFramesCtx = reinterpret_cast<AVHWFramesContext*>(avFrame->hw_frames_ctx->data);
AVPixelFormat actualFormat = hwFramesCtx->sw_format;Also: TIL that AVBufferRef* is effectively Object* for FFmpeg, and they use it to store lots of different generic stuff.
Dan-Flores
reviewed
Jul 18, 2025
| @pytest.mark.parametrize("asset", (H264_10BITS, H265_10BITS)) | ||
| def test_10bit_videos_cpu(self, asset): | ||
| # This just validates that we can decode 10-bit videos on CPU. | ||
| # TODO validate against the ref that the decoded frames are correct |
There was a problem hiding this comment.
What is required to test that the decoded frames are correct? It seems we would need to check in additional png files from each 10-bit video to the test/resources/, are there other changes needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #736 and #598.
Some 10bit videos are properly decoded by NVDEC, but are passed as-is to the NPP color conversion functions, which expect 8bits videos. This results in garbage output. This PR adds a check to prevent such incorrect conversion. It does not add support for 10 bit videos on CUDA. It just avoids silently wrong results.